Opened 5 years ago

Closed 5 years ago

#58 closed defect (fixed)

Server Browser broken in ioq3-synchro

Reported by: ilag Owned by: Tequila <tequila@…
Priority: normal Milestone: Smokin' Guns 1.2
Component: Client GUI and Experience Version: 1.2dev
Keywords: Cc:

Description

In the branch ioq3-synchro, the server browser is completely broken. Clicking the "Get New List" button throws this line into the console.
Unknown command "globalserversallmaster"
It seems that ioq3-synchro and newer versions of ioquake3 than the version in Smokin Guns 1.1 do not have this command.

Solution 1: Put this command back into the client. This allows for the client's latest engine to be used with 1.1's QVMs, allowing for backwards compatibility.

Solution 2: Alter how the "Get New List" function works to use only globalservers 5 times instead. This solution is not backwards-compatible, but would allow Smokin Guns to better keep track with ioquake3's updates.

Considering that I use ioq3-synchro's branch because it doesn't crash on startup when using a 64-bit game executable, backwards compatibility is important for now. When it comes time for 1.2's release, I believe that solution 2 is the better solution.

Attached is a patch implementing the backwards-compatible fix by bringing code from master into ioq3-synchro, and modifying it to work correctly.

Attachments (1)

ioq3-syncrho_server_browser_backwards_compatible.patch (3.3 KB) - added by ilag 5 years ago.
Patched described in ticket description.

Download all attachments as: .zip

Change History (3)

Changed 5 years ago by ilag

Patched described in ticket description.

comment:1 Changed 5 years ago by Téquila

Thank you for the patch, I'll check it deeper when I'll follow again the ioq3-synchro branch.
For now, as Biondo reached this issue, I quickly built a patched x86_64 build available at http://download.smokin-guns.org/binaries/dev/linux/

comment:2 Changed 5 years ago by Tequila <tequila@…

Owner: set to Tequila <tequila@…>
Resolution: fixed
Status: newclosed

In 954a7cd9e5dc71b4acd4128b4ab67a6e8c48f446/SmokinGuns:

Fix #58 - Server Browser broken in ioq3-synchro - Thanks to ilag
Kept backward compatibility with SG 1.1 getting back 'globalserversallmaster' code introduced by Joe Kari

Note: See TracTickets for help on using tickets.